Skip to Content Skip to Menu

Flow of payment gateway

  • krileon
  • krileon
  • ONLINE
  • Posts: 48536
  • Thanks: 8290
  • Karma: 1445
4 years 10 months ago #315997 by krileon
Replied by krileon on topic Flow of payment gateway
I don't believe so. Likely just a minor issue in the query that view is using.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

  • rbuelund
  • rbuelund
  • OFFLINE
  • Posts: 565
  • Thanks: 40
  • Karma: 4
4 years 9 months ago #316582 by rbuelund
Replied by rbuelund on topic Flow of payment gateway
Nothing new about getting the updated QuickPay gateway into the CBSubs package ??

Please Log in or Create an account to join the conversation.

  • krileon
  • krileon
  • ONLINE
  • Posts: 48536
  • Thanks: 8290
  • Karma: 1445
4 years 9 months ago #316585 by krileon
Replied by krileon on topic Flow of payment gateway
Looks better than the previous builds sent. Unsure why you're doing checksum validation in handleNotification as it's handled by _returnParamsHandler via _pspVerifySignature function call. Looks like your getSubscriptionRequstParams usage won't take into account different initial price from regular price (if period1 exists use mc_amount1 otherwise set price to mc_amount3). Aside from that there's not much I can suggest without reviewing Quickpay API further. As explained earlier this was not allotted for in my schedule when I scheduled tasks basically months in advance.

I've no idea when/if this will be implemented; we will of course have to make modifications, code cleanup, testing, etc.. It's not much different than contributing to a project on Github and is important to follow that projects code quality. For example you've completely altered the code style to your own and all of that will have to be cleaned up and redone.

With that said at a glance I don't see any security concerns so should be perfectly fine for you and your customers to use if it's working in your tests.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

  • rbuelund
  • rbuelund
  • OFFLINE
  • Posts: 565
  • Thanks: 40
  • Karma: 4
4 years 9 months ago #316600 by rbuelund
Replied by rbuelund on topic Flow of payment gateway
Hmmm, you write: "Looks like your getSubscriptionRequstParams usage won't take into account " - but it works with initial price?
I would like to alter the code style so that it matches your code style - but I need to know how you want it. I have been working in PHPStorm with this project.

Please Log in or Create an account to join the conversation.

  • rbuelund
  • rbuelund
  • OFFLINE
  • Posts: 565
  • Thanks: 40
  • Karma: 4
4 years 9 months ago #316601 by rbuelund
Replied by rbuelund on topic Flow of payment gateway
For example is it something like this I must alter the code against : www.php-fig.org/psr/psr-12/ ?

Please Log in or Create an account to join the conversation.

  • krileon
  • krileon
  • ONLINE
  • Posts: 48536
  • Thanks: 8290
  • Karma: 1445
4 years 9 months ago #316602 by krileon
Replied by krileon on topic Flow of payment gateway

Hmmm, you write: "Looks like your getSubscriptionRequstParams usage won't take into account " - but it works with initial price?

The 'amount' should be based off mc_amount1 if period1 exists otherwise it should be mc_amount3. This allows for different initial price/duration functionality to work (the scheduler will schedule the first renewal after initial duration if supplied). This should typically override mc_gross for the form. See CCBill for example.

I would like to alter the code style so that it matches your code style - but I need to know how you want it. I have been working in PHPStorm with this project.

Just follow the same styling as existing code. We don't have an official formatter for phpstorm.

I've finished a few tasks early and moved a few things around. Will be reviewing this further, making adjustments where necessary, and will see if we can have recurring payments for quickpay released sometime in the coming weeks.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in or Create an account to join the conversation.

Moderators: beatnantkrileon
Powered by Kunena Forum