[#2170] Random br in CB Login Module

In the CB Login Module 1.3.1, when displaying in Horizontal mode with the Default display type, and with Private Messages notification turned on, there's a bizarre BR tag thrown into the code for no apparent reason:

[code:1]
<a href=" dev.friendlyphotozone.com/component/uddeim/?task=inbox " class="mod_login flush right-floater custom-login" id="mod_login_pmsimg_flush_right-floater_custom-login"> dev.friendlyphotozone.com/modules/mod_cblogin/mod_cblogin/mail.gif " width="14" height="15" alt="NEW" class="mod_login flush right-floater custom-login" id="mod_login_messagesimg_flush_right-floater_custom-login" />
<br />
<a href=" dev.friendlyphotozone.com/component/uddeim/?task=inbox " class="mod_login flush right-floater custom-login" id="mod_login_pmsa_flush_right-floater_custom-login">
<span id="mod_login_messagestext_flush_right-floater_custom-login">You have 1 new private message</span></a>
[/code:1]

The BR tag splits the mail icon and the notification text over two lines. It's been there since many versions ago. I usually end up fixing it in the code, but I'm tired of always coming across this issue every time there's a new version of the module.

edit: it's present in Vertical mode too

Post edited by: GoremanX, at: 2011/01/05 20:36

Post edited by: krileon, at: 2011/01/06 15:50

Have reviewed source and I only see a BR being added after private message notification icon. Everywhere else won't display BR unless you're using vertical display. It's possible the BR is being placed by something else.

Please review your CB login module parameters to ensure no greeting or something of the sort is placing a BR. Please also provide where you have fixed this issue numerous times so can better review your issue. Please ensure you upgraded your CB 1.3.1 module and are not using a previous released module.

Please re-review the code. It's on line 407 of file modules/mod_cblogin/mod_cblogin.php

In addition, the output of that module is quite messy. For example, the formatting of the message notification and connection notification are completely different. Connection notification is enclosed within a SPAN tag with a unique ID, which makes that line easy to target with CSS. But message notification is made up of 2 separate A tags which are not enclosed in anything. This makes it impossible to target that line as a single object.

Every time I try to style this module with my own stylesheet, I have no choice but to edit the module's source code to make it do what I need. The output is inconsistent and disorganized. It really needs to be cleaned up and streamlined.

Post edited by: GoremanX, at: 2011/01/05 21:52

Please re-review the code. It's on line 407 of file modules/mod_cblogin/mod_cblogin.php

Right, that is the only location I mentioned in my previous post that a BR is not conditional to horizontal display or not. Have created a bug ticket to have this issue addressed for next release.

forge.joomlapolis.com/issues/2170

It really needs to be cleaned up and streamlined.

We've just discussed recently a complete redesign of the login module. We've plans to streamline it and start over with something more up to date.

Suggestion for the redesign of the login module.

Make some icon upload fields in the admin control for the mod_cblogin so we can upload our own icons and set the size of them larger or smaller then the default ones.

On that can you tell us what lines in the mod_cblogin control the size of the login icon form background. We made new icons that are larger then default ones and the login icon keeps getting clipped off by the back ground submit button size.

We are using Joomla 1.7.1 with the newest set of CB files available 1.7