[SOLVED] [#8729] String missing in language file in 4.5.2 cb paid subscriptions

Hi,

I just upgraded CB community and CB paid subscriptions to 4.6.3 and 4.52. The following string does not appear in any language file

'OFFLINE_PAYMENT_ON_DATE_PENDING' which is used in line 401 of the following program 'components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/processors/offline/cbpaidsubscriptions.offline.php'

$notice = CBTxt::T( 'OFFLINE_PAYMENT_ON_DATE_PENDING', 'A payment made on [date] is currently pending.', array( '[date]' => cbpaidTimes::getInstance()->cbFormatDateInOfficialTz( $paymentBasket->getString( 'time_initiated' ) ) ) );

I'm not able to modify or translate that string.

Bernard Goutier

Looks like our language parser missed it for some reason. You can translate it still using language overrides in either your CB or CBSubs language plugin.

Hi,

I tried it using the override file, it didn't work, as the key didn't appear in any language file the override is not working and even if I put the key in the default language or the GB language. For the moment, I modified the code to put the french string instead.

I found another problem of translation for the status of invoice.

components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/templates/default/invoicelist/default.php

Line 70 seems like a code problem, 'payment_status' I got 'completed' and line for line 79 'payment_type' I got 'Bank', seems like a problem with key in the translation file.

Bernard Goutier

To translate it add the following language override.

Key: OFFLINE_PAYMENT_ON_DATE_PENDING
Text: Whatever you want it to say here.

This works fine in my tests when directly added to CBs default language overrides. See the below of it working.

Edit:

Display:

bgoutier wrote: Hi,
...

I found another problem of translation for the status of invoice.

components/com_comprofiler/plugin/user/plug_cbpaidsubscriptions/templates/default/invoicelist/default.php

Line 70 seems like a code problem, 'payment_status' I got 'completed' and line for line 79 'payment_type' I got 'Bank', seems like a problem with key in the translation file.
...

Merci for reporting this. We should have an improvement with new strings for those soon:
forge.joomlapolis.com/issues/8729

(And will then add those strings that are known (some of those depend on the payment processor, so will not all be included, only most popular ones will be included) also add the missing string OFFLINE_PAYMENT_ON_DATE_PENDING for official translations too).

Hi,

Didn't work,

There is no override file before susbtitution, included override file after susbtitution from default language and snapshot of the results.

Bernard Goutier.