Please Log in or Create an account to join the conversation.
Please Log in or Create an account to join the conversation.
First of all excelent job!
Nice to see people are starting to get the hang of the plugin API - I am certainly having a great time learning a great deal.
While working on the hello world plugin (see here ) I had to re-read the API documentation (see download area) and continuously refer back to it. Also had some questions for Beat about guidelines that should be followed to avoid future problems etc.
Looking at your plugin I have identified the following issues:
Section 1.2 of the API - Plug-in naming states that the plugin names that start with cb should be avoided since they are reserved for core CB Team plugins. So you should rename your cb.xspfplayer.xml and cb.xspfplayer.xml (to get rid of the cb in the begining) and also modify the <filename plugin="cb.xspfplayer">cb.xspfplayer.php</filename> line in the xml file.
also your class="getXSPFPlayerTab" assignment in the XML file should be renamed to all lower case except the Tab. So it should be getxspfplayerTab. This is something that wasn't stated in the API doc (but Beat will update it). Its for compatibility with Unix systems that are case sensitive.
Not sure how the actual code works but shouldn't your "" (No) values in the XML parameter definitions be something like "&autoplay=false" ?
In your php file you should change the $xspfap = $params->get('xspfap', ''); type statements and instead of '' you should put the default values of the parameters (if the previous comment is not valid then these are just fine)
Please Log in or Create an account to join the conversation.
Please Log in or Create an account to join the conversation.
Please Log in or Create an account to join the conversation.
Please Log in or Create an account to join the conversation.